Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
.in.spec.tsfiles mirroring the Mocha originals with 1:1 test parity (93 total test cases)superagentwith Node's built-inhttpmodule in test helpers to avoid circular reference crashes in Jest workersassert.*()assertions to Jestexpect().*matchersbefore()/after()tobeforeAll()/afterAll()andforEach()version loops todescribe.each()jest-global-setup.tsto generateconfig/version.jsonin worktree environments wheregit rev-parsefailsjest-global-teardown.tsto clean up the generatedversion.jsonIssue
Closes: https://mozilla-hub.atlassian.net/browse/FXA-12622
Checklist
Other Information
Stability: Ran
yarn test-integration-jest5 times consecutively — all 417 tests passed on every run with zero flakes.No Mocha files removed in this PR. The original
.jstest files remain until the full migration is complete and the Mocha runner can be retired.Test Parity: Mocha vs Jest
attached_clients_tests.jsdevice_tests.jsdevice_tests_refresh_tokens.jsmisc_tests.jsoauth_tests.jsoauth_session_token_scope_tests.jssession_tests.jspush_db_tests.jspushbox_dbpushbox/db.tssign_key_tests.js