Allow unknown codecs when the ParseStrictness is not Strict#438
Open
AdrianEddy wants to merge 6 commits intomozilla:masterfrom
Open
Allow unknown codecs when the ParseStrictness is not Strict#438AdrianEddy wants to merge 6 commits intomozilla:masterfrom
AdrianEddy wants to merge 6 commits intomozilla:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated version of #420
Sample file with unknown video codec:
https://drive.google.com/file/d/1DS7u06qy_6dS2wYwK45lscAn_ZnF4e_x/view?usp=sharing
Sample file with unknown atoms in the wave atom:
https://drive.google.com/file/d/1NbX5QlSR8BLuHK2uj0lm14yJ0DJ3jT4H/view?usp=sharing
This PR changes the behavior of the parsing of wave atom and video_sample_entry such that it doesn't fail when that atom contains unknown (not implemented) boxes and codecs.
Instead of failing to parse the entire file, just skip that box and leave codec_specific as None.
If ParseStrictness is Strict, the behavior is not changed, the parser will fail