Fix parsing of ambiguous date formats like Hm#21606
Merged
Merged
Conversation
We support having hours/minutes numbers with one or two digits for strings like "1:30:31" but if the format is for example Hm, then "12" is really ambiguous. So the idea is to match the longest string as possible.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21606 +/- ##
=======================================
Coverage 89.84% 89.84%
=======================================
Files 263 263
Lines 66757 66758 +1
=======================================
+ Hits 59976 59981 +5
+ Misses 6781 6777 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We support having hours/minutes numbers with one or two digits for strings like "1:30:31" but if the format is for example Hm, then "12" is really ambiguous. So the idea is to match the longest string as possible.