[api-minor] Convert getViewerPreferences to return data in a Map#21607
Conversation
Compared to regular Objects there's a number of advantages to using Maps: - They support proper iteration. - They have a simple way to check for the existence of data. - They have a simple/efficient way to check the number of elements. If this functionality was added today, I cannot imagine that we'd choose an Object for this data.
See commit eddd70a
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21607 +/- ##
=======================================
Coverage 89.84% 89.85%
=======================================
Files 263 263
Lines 66758 66762 +4
=======================================
+ Hits 59980 59989 +9
+ Misses 6778 6773 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
timvandermeij
left a comment
There was a problem hiding this comment.
r=me, with passing browser tests. Thanks!
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/45e963120908ff8/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/3db4a81d5782a83/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/3db4a81d5782a83/output.txt Total script time: 46.82 mins
Image differences available at: http://54.241.84.105:8877/3db4a81d5782a83/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/45e963120908ff8/output.txt Total script time: 79.63 mins
|
Compared to regular Objects there's a number of advantages to using Maps:
If this functionality was added today, I cannot imagine that we'd choose an Object for this data.