Improve the Ref.prototype.toString method a tiny bit#21618
Merged
Conversation
When getting/creating a new `Ref` instance, via the static `Ref.get` method, we already need to compute a cache-key. Since this key is identical to the format used by the `toString` method, we can avoid having to re-create that string (a lot) by also providing it to the `Ref` constructor.
Snuffleupagus
temporarily deployed
to
code-coverage
July 22, 2026 11:33 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 22, 2026 11:33 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 22, 2026 11:33 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 22, 2026 11:33 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 22, 2026 11:33 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 22, 2026 11:33 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 22, 2026 11:33 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
had a problem deploying
to
code-coverage
July 22, 2026 11:33 — with
GitHub Actions
Failure
GitHub Actions
Failure
Snuffleupagus
temporarily deployed
to
code-coverage
July 22, 2026 11:33 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 22, 2026 11:33 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 22, 2026 11:33 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 22, 2026 11:33 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 22, 2026 11:33 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 22, 2026 11:33 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 22, 2026 11:33 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 22, 2026 11:33 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Collaborator
Author
|
/botio browsertest |
Collaborator
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/285b8495f965bf9/output.txt |
Collaborator
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/047576fc3114198/output.txt |
Collaborator
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/285b8495f965bf9/output.txt Total script time: 18.11 mins
|
Collaborator
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/047576fc3114198/output.txt Total script time: 23.07 mins
|
timvandermeij
approved these changes
Jul 23, 2026
timvandermeij
left a comment
timvandermeij
left a comment
Collaborator
There was a problem hiding this comment.
Good idea; thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When getting/creating a new
Refinstance, via the staticRef.getmethod, we already need to compute a cache-key.Since this key is identical to the format used by the
toStringmethod, we can avoid having to re-create that string (a lot) by simply providing it to theRefconstructor.