[api-minor] Convert getOpenAction to return data in a Map#21621
Merged
Conversation
Compared to regular Objects there's a number of advantages to using Maps: - They support proper iteration. - They have a simple way to check for the existence of data. - They have a simple/efficient way to check the number of elements. If this functionality was added today, I cannot imagine that we'd choose an Object for this data.
Snuffleupagus
temporarily deployed
to
code-coverage
July 23, 2026 11:56 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 23, 2026 11:56 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 23, 2026 11:56 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 23, 2026 11:56 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 23, 2026 11:56 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 23, 2026 11:56 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 23, 2026 11:56 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 23, 2026 11:56 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 23, 2026 11:56 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 23, 2026 11:56 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 23, 2026 11:56 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 23, 2026 11:56 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 23, 2026 11:56 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 23, 2026 11:56 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 23, 2026 11:56 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 23, 2026 11:56 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21621 +/- ##
=======================================
Coverage 89.85% 89.85%
=======================================
Files 263 263
Lines 66769 66769
=======================================
+ Hits 59992 59996 +4
+ Misses 6777 6773 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
timvandermeij
approved these changes
Jul 23, 2026
timvandermeij
left a comment
timvandermeij
left a comment
Collaborator
There was a problem hiding this comment.
r=me, with passing browser tests. Thanks!
Collaborator
|
/botio browsertest |
Collaborator
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/5101c374aef39fa/output.txt |
Collaborator
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/da2f74a7f098306/output.txt |
Collaborator
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/5101c374aef39fa/output.txt Total script time: 18.32 mins
|
Collaborator
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/da2f74a7f098306/output.txt Total script time: 23.70 mins
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compared to regular Objects there's a number of advantages to using Maps:
If this functionality was added today, I cannot imagine that we'd choose an Object for this data.