Document the preserve and dependencyLists params for recordOperation#21622
Merged
timvandermeij merged 1 commit intoJul 23, 2026
Merged
Conversation
LuShadowX
had a problem deploying
to
code-coverage
July 23, 2026 18:35 — with
GitHub Actions
Failure
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21622 +/- ##
==========================================
- Coverage 89.85% 89.84% -0.01%
==========================================
Files 263 263
Lines 66769 66769
==========================================
- Hits 59992 59991 -1
- Misses 6777 6778 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
timvandermeij
approved these changes
Jul 23, 2026
Collaborator
|
Thank you for extending the docstrings! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two
recordOperationmethods incanvas_dependency_tracker.jshave a JSDoc block that only documentsidx, even though they also take apreserveflag (anddependencyListsin theCanvasBBoxTrackerversion).I filled in the missing
@paramentries based on how the arguments are used in each method. Docs only, no behavior change.