Skip to content

Document the preserve and dependencyLists params for recordOperation#21622

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
LuShadowX:document-recordoperation-params
Jul 23, 2026
Merged

Document the preserve and dependencyLists params for recordOperation#21622
timvandermeij merged 1 commit into
mozilla:masterfrom
LuShadowX:document-recordoperation-params

Conversation

@LuShadowX

Copy link
Copy Markdown
Contributor

The two recordOperation methods in canvas_dependency_tracker.js have a JSDoc block that only documents idx, even though they also take a preserve flag (and dependencyLists in the CanvasBBoxTracker version).

I filled in the missing @param entries based on how the arguments are used in each method. Docs only, no behavior change.

@codecov-commenter

codecov-commenter commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.84%. Comparing base (0c8f670) to head (388168a).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21622      +/-   ##
==========================================
- Coverage   89.85%   89.84%   -0.01%     
==========================================
  Files         263      263              
  Lines       66769    66769              
==========================================
- Hits        59992    59991       -1     
- Misses       6777     6778       +1     
Flag Coverage Δ
browsertest 66.57% <ø> (+<0.01%) ⬆️
fonttest 9.05% <ø> (ø)
integrationtest 69.24% <ø> (-0.01%) ⬇️
unittest 57.49% <ø> (-0.01%) ⬇️
unittestcli 56.45% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timvandermeij
timvandermeij merged commit 6332955 into mozilla:master Jul 23, 2026
19 of 21 checks passed
@timvandermeij

Copy link
Copy Markdown
Collaborator

Thank you for extending the docstrings!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants