Remove the objectSize helper function#21624
Merged
Merged
Conversation
Given that Maps are used a lot more these days, this helper function is now used very sparingly and inlining the necessary code seems reasonable. *Note:* Once [this proposal](https://github.com/tc39/proposal-object-keys-length) makes it into Firefox, we should be able to simplify all `Object.keys(...).length` call-sites.
Snuffleupagus
temporarily deployed
to
code-coverage
July 24, 2026 10:56 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 24, 2026 10:56 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 24, 2026 10:56 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 24, 2026 10:56 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 24, 2026 10:56 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 24, 2026 10:56 — with
GitHub Actions
Inactive
Snuffleupagus
had a problem deploying
to
code-coverage
July 24, 2026 10:56 — with
GitHub Actions
Failure
Snuffleupagus
temporarily deployed
to
code-coverage
July 24, 2026 10:56 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 24, 2026 10:56 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 24, 2026 10:56 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 24, 2026 10:56 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 24, 2026 10:56 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 24, 2026 10:56 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 24, 2026 10:56 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 24, 2026 10:56 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 24, 2026 10:56 — with
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21624 +/- ##
=======================================
Coverage 89.85% 89.85%
=======================================
Files 263 263
Lines 66809 66808 -1
=======================================
+ Hits 60029 60031 +2
+ Misses 6780 6777 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
timvandermeij
approved these changes
Jul 24, 2026
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given that Maps are used a lot more these days, this helper function is now used very sparingly and inlining the necessary code seems reasonable.
Note: Once this proposal makes it into Firefox, we should be able to simplify all
Object.keys(...).lengthcall-sites.