Skip to content

Remove the objectSize helper function#21624

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:rm-objectSize
Jul 24, 2026
Merged

Remove the objectSize helper function#21624
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:rm-objectSize

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

Given that Maps are used a lot more these days, this helper function is now used very sparingly and inlining the necessary code seems reasonable.

Note: Once this proposal makes it into Firefox, we should be able to simplify all Object.keys(...).length call-sites.

Given that Maps are used a lot more these days, this helper function is now used very sparingly and inlining the necessary code seems reasonable.

*Note:* Once [this proposal](https://github.com/tc39/proposal-object-keys-length) makes it into Firefox, we should be able to simplify all `Object.keys(...).length` call-sites.
@codecov-commenter

codecov-commenter commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.85%. Comparing base (fe0b880) to head (675e921).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21624   +/-   ##
=======================================
  Coverage   89.85%   89.85%           
=======================================
  Files         263      263           
  Lines       66809    66808    -1     
=======================================
+ Hits        60029    60031    +2     
+ Misses       6780     6777    -3     
Flag Coverage Δ
browsertest 66.53% <100.00%> (+<0.01%) ⬆️
fonttest 9.05% <0.00%> (+<0.01%) ⬆️
integrationtest 69.26% <100.00%> (+<0.01%) ⬆️
unittest 57.52% <100.00%> (+<0.01%) ⬆️
unittestcli 56.49% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@calixteman calixteman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@timvandermeij
timvandermeij merged commit 586c309 into mozilla:master Jul 24, 2026
20 of 21 checks passed
@timvandermeij

Copy link
Copy Markdown
Collaborator

Thanks!

@Snuffleupagus
Snuffleupagus deleted the rm-objectSize branch July 24, 2026 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants