Add the Firefox features notification bar to the viewer (bug 2057608)#21629
Open
calixteman wants to merge 1 commit into
Open
Add the Firefox features notification bar to the viewer (bug 2057608)#21629calixteman wants to merge 1 commit into
calixteman wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21629 +/- ##
==========================================
- Coverage 89.84% 89.82% -0.03%
==========================================
Files 263 263
Lines 66811 66837 +26
==========================================
+ Hits 60029 60036 +7
- Misses 6782 6801 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The bar itself (`<pdf-features-notification>`) ships from mozilla-central, so the viewer only hosts it. Finally the maximum number of preferences is raised to 60, to match the change made in mozilla-central in bug 2056102, since this adds a 51st one.
calixteman
force-pushed
the
notification_bar
branch
from
July 25, 2026 06:43
00cbc1b to
f195bec
Compare
calixteman
had a problem deploying
to
code-coverage
July 25, 2026 06:43 — with 
GitHub Actions
Failure
GitHub Actions
Failure
calixteman
had a problem deploying
to
code-coverage
July 26, 2026 10:07 — with
GitHub Actions
Failure
GitHub Actions
Failure
timvandermeij
approved these changes
Jul 26, 2026
timvandermeij
left a comment
timvandermeij
left a comment
Collaborator
There was a problem hiding this comment.
Looks good; thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bar itself (
<pdf-features-notification>) ships from mozilla-central, so the viewer only hosts it.Finally the maximum number of preferences is raised to 60, to match the change made in mozilla-central in bug 2056102, since this adds a 51st one.