Re-factor the XRef class to use private fields#21631
Merged
Merged
Conversation
Part of this is very old code, hence modernizing it a little bit more really shouldn't hurt. This patch also shortens some `XRef` code by using nullish coalescing assignment respectively ternary operators more. Finally, adds the recently introduced `countUpdatesAfter` method to the `XRefMock`/`XRefWrapper` classes to avoid having to check for its existence.
In the `pr4731.pdf` document the trailer is actually a Stream, rather than the expected Dictionary, hence update the "nested trailer dictionary" check to make that clearer. *Note:* This is something that I happened to noticed while working on the previous patch.
Snuffleupagus
temporarily deployed
to
code-coverage
July 25, 2026 10:22 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 25, 2026 10:22 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 25, 2026 10:22 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 25, 2026 10:22 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 25, 2026 10:22 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 25, 2026 10:22 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 25, 2026 10:22 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 25, 2026 10:22 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
had a problem deploying
to
code-coverage
July 25, 2026 10:22 — with
GitHub Actions
Failure
GitHub Actions
Failure
Snuffleupagus
temporarily deployed
to
code-coverage
July 25, 2026 10:22 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 25, 2026 10:22 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
had a problem deploying
to
code-coverage
July 25, 2026 10:22 — with
GitHub Actions
Failure
GitHub Actions
Failure
Snuffleupagus
temporarily deployed
to
code-coverage
July 25, 2026 10:22 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 25, 2026 10:22 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 25, 2026 10:22 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 25, 2026 10:22 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21631 +/- ##
=======================================
Coverage 89.84% 89.85%
=======================================
Files 263 263
Lines 66811 66802 -9
=======================================
- Hits 60029 60023 -6
+ Misses 6782 6779 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Snuffleupagus
temporarily deployed
to
code-coverage
July 25, 2026 10:30 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Collaborator
Author
|
/botio browsertest |
Collaborator
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/fcd096ae68bc8af/output.txt |
Collaborator
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/aa3507aedadde49/output.txt |
Collaborator
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/fcd096ae68bc8af/output.txt Total script time: 18.02 mins
|
Snuffleupagus
marked this pull request as ready for review
July 25, 2026 11:11
Collaborator
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/aa3507aedadde49/output.txt Total script time: 23.06 mins
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-factor the
XRefclass to use private fieldsPart of this is very old code, hence modernizing it a little bit more really shouldn't hurt.
This patch also shortens some
XRefcode by using nullish coalescing assignment respectively ternary operators more.Finally, adds the recently introduced
countUpdatesAftermethod to theXRefMock/XRefWrapperclasses to avoid having to check for its existence.Re-factor the "nested trailer dictionary" check (PR 4731 follow-up)
In the
pr4731.pdfdocument the trailer is actually a Stream, rather than the expected Dictionary, hence update the "nested trailer dictionary" check to make that clearer.Note: This is something that I happened to noticed while working on the previous patch.