Skip to content

Use the toBeFalse() matcher consistently in the unit/integration tests #21634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Snuffleupagus merged 1 commit into from
Jul 25, 2026
+201 −201
Merged

Use the toBeFalse() matcher consistently in the unit/integration tests #21634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions test/integration/annotation_spec.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ describe("Annotation highlight", () => {
getAnnotationSelector("21R"),
el => el.hidden
);
expect(hidden).withContext(`In ${browserName}`).toEqual(false);
expect(hidden).withContext(`In ${browserName}`).toBeFalse();
})
);
});
Expand Down Expand Up @@ -346,10 +346,10 @@ describe("Annotation and storage", () => {
expect(checked).toEqual(true);

checked = await page.$eval(getSelector(radio1Id), el => el.checked);
expect(checked).toEqual(false);
expect(checked).toBeFalse();

checked = await page.$eval(getSelector(radio2Id), el => el.checked);
expect(checked).toEqual(false);
expect(checked).toBeFalse();
}

// Change data on page 5 and check that other pages changed.
Expand Down Expand Up @@ -384,13 +384,13 @@ describe("Annotation and storage", () => {
getSelector(checkId),
el => el.checked
);
expect(checked).toEqual(false);
expect(checked).toBeFalse();

checked = await page.$eval(getSelector(radio1Id), el => el.checked);
expect(checked).toEqual(false);
expect(checked).toBeFalse();

checked = await page.$eval(getSelector(radio2Id), el => el.checked);
expect(checked).toEqual(false);
expect(checked).toBeFalse();
}
})
);
Expand Down Expand Up @@ -442,7 +442,7 @@ describe("ResetForm action", () => {
getSelector(`${id}R`),
el => el.checked
);
expect(checked).withContext(`In ${browserName}`).toEqual(false);
expect(checked).withContext(`In ${browserName}`).toBeFalse();
}

let selected = await page.$eval(
Expand Down Expand Up @@ -495,7 +495,7 @@ describe("ResetForm action", () => {
);
expect(checked)
.withContext(`In ${browserName + id}`)
.toEqual(false);
.toBeFalse();
}

ids = [71, 75];
Expand Down Expand Up @@ -644,7 +644,7 @@ describe("ResetForm action", () => {
`document.querySelector('${selector}').hidden !== true`
);
hidden = await page.$eval(selector, el => el.hidden);
expect(hidden).withContext(`In ${browserName}`).toEqual(false);
expect(hidden).withContext(`In ${browserName}`).toBeFalse();

await page.keyboard.press("Enter");
await page.waitForFunction(
Expand All @@ -658,7 +658,7 @@ describe("ResetForm action", () => {
`document.querySelector('${selector}').hidden !== true`
);
hidden = await page.$eval(selector, el => el.hidden);
expect(hidden).withContext(`In ${browserName}`).toEqual(false);
expect(hidden).withContext(`In ${browserName}`).toBeFalse();

await page.keyboard.press("Escape");
await page.waitForFunction(
Expand Down
2 changes: 1 addition & 1 deletion test/integration/comment_spec.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -912,7 +912,7 @@ describe("Comment", () => {
),
editorSelector
);
expect(hasCommentButton).withContext(`In ${browserName}`).toBe(false);
expect(hasCommentButton).withContext(`In ${browserName}`).toBeFalse();
})
);
});
Expand Down
2 changes: 1 addition & 1 deletion test/integration/freetext_editor_spec.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ describe("FreeText Editor", () => {
sel => !!document.querySelector(sel),
getEditorSelector(n)
);
expect(hasEditor).withContext(`In ${browserName}`).toEqual(false);
expect(hasEditor).withContext(`In ${browserName}`).toBeFalse();
}
})
);
Expand Down
4 changes: 2 additions & 2 deletions test/integration/highlight_editor_spec.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -886,7 +886,7 @@ describe("Highlight Editor", () => {
});
expect(editingEvent.isEditing)
.withContext(`In ${browserName}`)
.toBe(false);
.toBeFalse();
expect(editingEvent.hasSelectedText)
.withContext(`In ${browserName}`)
.toBe(true);
Expand All @@ -901,7 +901,7 @@ describe("Highlight Editor", () => {
});
expect(editingEvent.hasSelectedText)
.withContext(`In ${browserName}`)
.toBe(false);
.toBeFalse();

await page.mouse.click(x, y, { count: 2, delay: 100 });
await page.waitForFunction(() => window.editingEvents.length > 0);
Expand Down
6 changes: 3 additions & 3 deletions test/integration/scripting_spec.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ describe("Interaction", () => {
expect(text).toEqual("");

checked = await page.$eval(getSelector("449R"), el => el.checked);
expect(checked).toEqual(false);
expect(checked).toBeFalse();

const visibility = await page.$eval(
getSelector("427R"),
Expand Down Expand Up @@ -2023,7 +2023,7 @@ describe("Interaction", () => {
);

readonly = await page.$eval(getSelector("353R"), el => el.disabled);
expect(readonly).withContext(`In ${browserName}`).toEqual(false);
expect(readonly).withContext(`In ${browserName}`).toBeFalse();

await page.click(getSelector("353R"));
await page.waitForFunction(
Expand All @@ -2043,7 +2043,7 @@ describe("Interaction", () => {
readonly = await page.$eval(getSelector("353R"), el => el.disabled);
expect(readonly).withContext(`In ${browserName}`).toEqual(true);
checked = await page.$eval(getSelector("353R"), el => el.checked);
expect(checked).withContext(`In ${browserName}`).toEqual(false);
expect(checked).withContext(`In ${browserName}`).toBeFalse();
})
);
});
Expand Down
2 changes: 1 addition & 1 deletion test/integration/viewer_spec.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -835,7 +835,7 @@ describe("PDF viewer", () => {
);

expect(isSame).withContext(`In ${browserName}`).toBe(true);
expect(rendered).withContext(`In ${browserName}`).toBe(false);
expect(rendered).withContext(`In ${browserName}`).toBeFalse();
});
});
});
Expand Down
66 changes: 33 additions & 33 deletions test/unit/annotation_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,8 +381,8 @@ describe("annotation", function () {
expect(annotation.hasFlag(AnnotationFlag.INVISIBLE)).toEqual(true);
expect(annotation.hasFlag(AnnotationFlag.NOZOOM)).toEqual(true);
expect(annotation.hasFlag(AnnotationFlag.PRINT)).toEqual(true);
expect(annotation.hasFlag(AnnotationFlag.READONLY)).toEqual(false);
expect(annotation.hasFlag(AnnotationFlag.HIDDEN)).toEqual(false);
expect(annotation.hasFlag(AnnotationFlag.READONLY)).toBeFalse();
expect(annotation.hasFlag(AnnotationFlag.HIDDEN)).toBeFalse();
});

it("should be viewable and not printable by default", function () {
Expand All @@ -394,7 +394,7 @@ describe("annotation", function () {
});

expect(annotation.viewable).toEqual(true);
expect(annotation.printable).toEqual(false);
expect(annotation.printable).toBeFalse();
});

it("should set and get a valid rectangle", function () {
Expand Down Expand Up @@ -1603,10 +1603,10 @@ describe("annotation", function () {
expect(data.annotationType).toEqual(AnnotationType.WIDGET);
expect(data.textAlignment).toBeNull();
expect(data.maxLen).toEqual(0);
expect(data.readOnly).toEqual(false);
expect(data.hidden).toEqual(false);
expect(data.multiLine).toEqual(false);
expect(data.comb).toEqual(false);
expect(data.readOnly).toBeFalse();
expect(data.hidden).toBeFalse();
expect(data.multiLine).toBeFalse();
expect(data.comb).toBeFalse();
expect(data.defaultFieldValue).toEqual("foo");
});

Expand All @@ -1627,10 +1627,10 @@ describe("annotation", function () {
expect(data.annotationType).toEqual(AnnotationType.WIDGET);
expect(data.textAlignment).toBeNull();
expect(data.maxLen).toEqual(0);
expect(data.readOnly).toEqual(false);
expect(data.hidden).toEqual(false);
expect(data.multiLine).toEqual(false);
expect(data.comb).toEqual(false);
expect(data.readOnly).toBeFalse();
expect(data.hidden).toBeFalse();
expect(data.multiLine).toBeFalse();
expect(data.comb).toBeFalse();
});

it("should set valid text alignment, maximum length and flags", async function () {
Expand All @@ -1654,7 +1654,7 @@ describe("annotation", function () {
expect(data.textAlignment).toEqual(1);
expect(data.maxLen).toEqual(20);
expect(data.readOnly).toEqual(true);
expect(data.hidden).toEqual(false);
expect(data.hidden).toBeFalse();
expect(data.multiLine).toEqual(true);
});

Expand All @@ -1671,7 +1671,7 @@ describe("annotation", function () {
idFactoryMock
);
expect(data.annotationType).toEqual(AnnotationType.WIDGET);
expect(data.comb).toEqual(false);
expect(data.comb).toBeFalse();
});

it("should accept comb fields with a maximum length", async function () {
Expand Down Expand Up @@ -2563,7 +2563,7 @@ describe("annotation", function () {
expect(data.checkBox).toEqual(true);
expect(data.fieldValue).toEqual("Checked");
expect(data.defaultFieldValue).toEqual("Off");
expect(data.radioButton).toEqual(false);
expect(data.radioButton).toBeFalse();
expect(data.exportValue).toEqual("Checked");
});

Expand Down Expand Up @@ -2595,7 +2595,7 @@ describe("annotation", function () {
);
expect(data.annotationType).toEqual(AnnotationType.WIDGET);
expect(data.checkBox).toEqual(true);
expect(data.radioButton).toEqual(false);
expect(data.radioButton).toBeFalse();
expect(data.exportValue).toEqual("I Agree to terms");
expect(data.fieldValue).toEqual("I Agree to terms");
expect(data.defaultFieldValue).toEqual("I Agree to terms");
Expand Down Expand Up @@ -2635,7 +2635,7 @@ describe("annotation", function () {
);
expect(data.annotationType).toEqual(AnnotationType.WIDGET);
expect(data.checkBox).toEqual(true);
expect(data.radioButton).toEqual(false);
expect(data.radioButton).toBeFalse();
expect(data.exportValue).toEqual("I Agree to terms");
expect(data.fieldValue).toEqual("I Agree to terms");
expect(data.defaultFieldValue).toEqual("I Agree to terms");
Expand All @@ -2660,7 +2660,7 @@ describe("annotation", function () {
expect(data.checkBox).toEqual(true);
expect(data.fieldValue).toEqual("Checked");
expect(data.defaultFieldValue).toEqual("Off");
expect(data.radioButton).toEqual(false);
expect(data.radioButton).toBeFalse();
});

it("should handle checkboxes without /Off appearance", async function () {
Expand Down Expand Up @@ -2689,7 +2689,7 @@ describe("annotation", function () {
expect(data.checkBox).toEqual(true);
expect(data.fieldValue).toEqual("Checked");
expect(data.defaultFieldValue).toEqual("Off");
expect(data.radioButton).toEqual(false);
expect(data.radioButton).toBeFalse();
expect(data.exportValue).toEqual("Checked");
});

Expand Down Expand Up @@ -3123,7 +3123,7 @@ describe("annotation", function () {
idFactoryMock
);
expect(data.annotationType).toEqual(AnnotationType.WIDGET);
expect(data.checkBox).toEqual(false);
expect(data.checkBox).toBeFalse();
expect(data.radioButton).toEqual(true);
expect(data.fieldValue).toEqual("1");
expect(data.buttonValue).toEqual("2");
Expand Down Expand Up @@ -3276,7 +3276,7 @@ describe("annotation", function () {
idFactoryMock
);
expect(data.annotationType).toEqual(AnnotationType.WIDGET);
expect(data.checkBox).toEqual(false);
expect(data.checkBox).toBeFalse();
expect(data.radioButton).toEqual(true);
expect(data.fieldValue).toEqual(name);
expect(data.buttonValue).toEqual(name);
Expand Down Expand Up @@ -3304,7 +3304,7 @@ describe("annotation", function () {
idFactoryMock
);
expect(data.annotationType).toEqual(AnnotationType.WIDGET);
expect(data.checkBox).toEqual(false);
expect(data.checkBox).toBeFalse();
expect(data.radioButton).toEqual(true);
expect(data.fieldValue).toBeNull();
expect(data.buttonValue).toEqual("2");
Expand Down Expand Up @@ -4008,10 +4008,10 @@ describe("annotation", function () {
idFactoryMock
);
expect(data.annotationType).toEqual(AnnotationType.WIDGET);
expect(data.readOnly).toEqual(false);
expect(data.hidden).toEqual(false);
expect(data.combo).toEqual(false);
expect(data.multiSelect).toEqual(false);
expect(data.readOnly).toBeFalse();
expect(data.hidden).toBeFalse();
expect(data.combo).toBeFalse();
expect(data.multiSelect).toBeFalse();
});

it("should not set invalid flags", async function () {
Expand All @@ -4029,10 +4029,10 @@ describe("annotation", function () {
idFactoryMock
);
expect(data.annotationType).toEqual(AnnotationType.WIDGET);
expect(data.readOnly).toEqual(false);
expect(data.hidden).toEqual(false);
expect(data.combo).toEqual(false);
expect(data.multiSelect).toEqual(false);
expect(data.readOnly).toBeFalse();
expect(data.hidden).toBeFalse();
expect(data.combo).toBeFalse();
expect(data.multiSelect).toBeFalse();
});

it("should set valid flags", async function () {
Expand All @@ -4056,7 +4056,7 @@ describe("annotation", function () {
);
expect(data.annotationType).toEqual(AnnotationType.WIDGET);
expect(data.readOnly).toEqual(true);
expect(data.hidden).toEqual(false);
expect(data.hidden).toBeFalse();
expect(data.combo).toEqual(true);
expect(data.multiSelect).toEqual(true);
});
Expand Down Expand Up @@ -4658,7 +4658,7 @@ describe("annotation", function () {
idFactoryMock
);
expect(data.annotationType).toEqual(AnnotationType.RICHMEDIA);
expect(data.noHTML).toEqual(false);
expect(data.noHTML).toBeFalse();
expect(data.richMedia).toEqual({
fileId: "attachmentRef:100R",
filename: "demo.mp4",
Expand Down Expand Up @@ -5017,7 +5017,7 @@ describe("annotation", function () {
idFactoryMock
);
expect(data.annotationType).toEqual(AnnotationType.SCREEN);
expect(data.noHTML).toEqual(false);
expect(data.noHTML).toBeFalse();
expect(data.richMedia).toEqual({
fileId: "attachmentRef:200R",
filename: "demo.mp3",
Expand Down Expand Up @@ -5272,7 +5272,7 @@ describe("annotation", function () {
idFactoryMock
);
expect(data.annotationType).toEqual(AnnotationType.SOUND);
expect(data.noHTML).toEqual(false);
expect(data.noHTML).toBeFalse();
expect(data.richMedia).toEqual({
fileId: "attachmentRef:300R",
filename: "sound.wav",
Expand Down
4 changes: 2 additions & 2 deletions test/unit/annotation_storage_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ describe("AnnotationStorage", function () {
// not changing value
called = false;
annotationStorage.setValue("asdf", { value: "modified" });
expect(called).toBe(false);
expect(called).toBeFalse();
});
});

Expand All @@ -101,7 +101,7 @@ describe("AnnotationStorage", function () {
// not changing value
annotationStorage.setValue("asdf", { value: "original" });
annotationStorage.resetModified();
expect(called).toBe(false);
expect(called).toBeFalse();

// changing value
annotationStorage.setValue("asdf", { value: "modified" });
Expand Down
Loading