Skip to content

Use the toBeTrue() matcher consistently in the unit/font/integration tests#21635

Merged
Snuffleupagus merged 1 commit into
mozilla:masterfrom
Snuffleupagus:test-toBeTrue
Jul 25, 2026
Merged

Use the toBeTrue() matcher consistently in the unit/font/integration tests#21635
Snuffleupagus merged 1 commit into
mozilla:masterfrom
Snuffleupagus:test-toBeTrue

Conversation

@Snuffleupagus

@Snuffleupagus Snuffleupagus commented Jul 25, 2026

Copy link
Copy Markdown
Collaborator

This replaces all toEqual(true) and toBe(true) occurrences.

@codecov-commenter

codecov-commenter commented Jul 25, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.84%. Comparing base (a97d0aa) to head (62d211e).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #21635   +/-   ##
=======================================
  Coverage   89.83%   89.84%           
=======================================
  Files         263      263           
  Lines       66802    66802           
=======================================
+ Hits        60014    60017    +3     
+ Misses       6788     6785    -3
Flag Coverage Δ
fonttest 9.05% <ø> (ø)
integrationtest 69.24% <ø> (-0.01%) ⬇️
unittest 57.52% <ø> (+0.02%) ⬆️
unittestcli 56.49% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

calixteman
calixteman approved these changes Jul 25, 2026
View reviewed changes

@calixteman calixteman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus
Use the toBeTrue() matcher consistently in the unit/font/integratio…
62d211e 
…n tests

This replaces all `toEqual(true)` and `toBe(true)` occurrences.
@Snuffleupagus
Snuffleupagus merged commit e2d6021 into mozilla:master Jul 25, 2026
19 of 20 checks passed
@Snuffleupagus
Snuffleupagus deleted the test-toBeTrue branch July 25, 2026 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@calixteman calixteman calixteman approved these changes

Assignees

No one assigned

Labels

test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Snuffleupagus @codecov-commenter @calixteman