Convert the /Indexed palette in a single base color space call#21637
Open
calixteman wants to merge 1 commit into
Open
Convert the /Indexed palette in a single base color space call#21637calixteman wants to merge 1 commit into
calixteman wants to merge 1 commit into
Conversation
`IndexedCS` invoked the base color space once per palette entry, which is cheap for e.g. `DeviceRgbCS` but not for `IccColorSpace` where every call is a Wasm round-trip.
calixteman
had a problem deploying
to
code-coverage
July 25, 2026 19:09 — with 
GitHub Actions
Failure
GitHub Actions
Failure
calixteman
had a problem deploying
to
code-coverage
July 25, 2026 19:09 — with
GitHub Actions
Failure
GitHub Actions
Failure
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21637 +/- ##
=======================================
Coverage 89.84% 89.85%
=======================================
Files 263 263
Lines 66811 66816 +5
=======================================
+ Hits 60029 60036 +7
+ Misses 6782 6780 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
|
||
| constructor(base, highVal, lookup) { | ||
| super("Indexed", 1); | ||
| this.base = base; |
Collaborator
There was a problem hiding this comment.
Nit: This line might no longer be needed now?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IndexedCSinvoked the base color space once per palette entry, which is cheap for e.g.DeviceRgbCSbut not forIccColorSpacewhere every call is a Wasm round-trip.