Skip to content

test(core): fix flaky image-sanitization logger assertion #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lmorchard wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

test(core): fix flaky image-sanitization logger assertion #571

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/core/test/loggers.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -975,8 +975,10 @@ describe("JSONConsoleLogger", () => {
expect(imageBlock.type).toBe("image");
expect(imageBlock.data).toBe("<omitted>");
expect(imageBlock.size).toBe(fakeJpeg.byteLength);
// Raw byte array must not appear in the output
expect(output).not.toContain("255"); // 0xff byte value
// Raw byte array must not appear in the output. Match the serialized
// byte sequence rather than a bare "255" — the latter collides with
// the millisecond timestamp in the output and makes this test flaky.
expect(output).not.toContain("255,216,255"); // raw fakeJpeg bytes
});

it("should preserve raw image data when sanitizeGenerationImages is false", () => {
Expand Down
Loading