Refactor away from inheriting from Icode.#2428
Merged
Merged
Conversation
andreabergia
approved these changes
Jun 9, 2026
Collaborator
|
Looks great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next bit of prep for #2426.
CodeGeneratorandInterpreterboth inherited fromIcodeas an old trick to avoid large numbers of static imports. As part of introducing a new interpreter we want to be able to inherit from an abstract class which itself should not inherit fromIcode.I chose to fix this by removing all the initial
Icode_prefixes. This allows all the use sites to change simply fromIcode_THINGtoIcode.THINGand avoids either starred static imports or large numbers of static imports.