Implement WeakRef#2431
Merged
Merged
Conversation
Collaborator
Author
|
And to be clear about that previous PR, I plan to start with the commit by @anivar so that he also gets credit in the commit log. |
andreabergia
left a comment
andreabergia
left a comment
Contributor
There was a problem hiding this comment.
Looks nice and simple!
Collaborator
Author
|
Yes, there is not too much to this one. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement WeakRef. We have another PR for this but I wanted to get this done
one feature at a time.
When this is done I will use the work already done in
#2058
to implement FinalizationRegistry, although I would like to adapt that a bit since
I think that the cleanup callbacks need to run in a different way.