Skip to content

Improve SCCACHE_BASEDIRS support#2576

Open
sylvestre wants to merge 1 commit intomozilla:mainfrom
sylvestre:sccache-dir
Open

Improve SCCACHE_BASEDIRS support#2576
sylvestre wants to merge 1 commit intomozilla:mainfrom
sylvestre:sccache-dir

Conversation

@sylvestre
Copy link
Collaborator

No description provided.

@sylvestre sylvestre marked this pull request as ready for review January 28, 2026 11:33
@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 91.42857% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.04%. Comparing base (5154084) to head (aed7d53).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/util.rs 91.42% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2576   +/-   ##
=======================================
  Coverage   72.04%   72.04%           
=======================================
  Files          66       66           
  Lines       36953    36969   +16     
=======================================
+ Hits        26623    26635   +12     
- Misses      10330    10334    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

we had `to_lowercase()` on each character in a loop, causing repeated heap allocations.
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 2, 2026

CodSpeed Performance Report

Merging this PR will degrade performance by 4.57%

Comparing sylvestre:sccache-dir (aed7d53) with main (5154084)

Summary

❌ 2 regressed benchmarks
✅ 60 untouched benchmarks
⏩ 2 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation normalize_win_path_typical 1.6 µs 1.7 µs -4.57%
Simulation normalize_win_path_utf8 3.3 µs 3.5 µs -4.31%

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants