Conversation
…immediate block logic
Tibap
previously approved these changes
Mar 11, 2026
Contributor
Tibap
left a comment
Tibap
left a comment
There was a problem hiding this comment.
Just updated the description to include more details about this change. Otherwise looks good to me, let's test if this works.
sseehra
requested review from
bkochendorfer,
jasonthomas,
jbuck and
whd
as code owners
bkochendorfer
previously approved these changes
Mar 11, 2026
Contributor
Release plan
|
bkochendorfer
previously approved these changes
Mar 12, 2026
bkochendorfer
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a
new ngwaf_baseline_protectionparameter to enable configuration of a "baseline WAF protection" profile. The goal is to apply a standardized level of protection to non-critical applications for which we do not plan to develop custom rules.Since the
immediate_blockingfeature can result in blocking legitimate traffic, the baseline protection uses a default threshold that should balance security and usability.Protection behavior is:
ngwaf_baseline_protectionparameter is passed to the module, immediate blocking is disabled and the following thresholds are used: 3 attacks in 1 minute, 10 attacks in 10 minutes, 60 attacks in 60 minutes.Related Tickets & Documents