Conversation
Closed
nnethercote
approved these changes
Dec 5, 2022
Contributor
nnethercote
left a comment
nnethercote
left a comment
There was a problem hiding this comment.
Looks good. I did a light review with lots of skimming based on the assumption that the original std code is good.
Contributor
|
This might be a good time to mention that I was also missing |
Collaborator
Author
|
drain_filter is more dubious as an API, would https://doc.rust-lang.org/stable/std/vec/struct.Drain.html#method.keep_rest |
The impl is a copy-paste of the one in std. Seemingly no significant modifications were necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The impl is a copy-paste of the one in std. Seemingly no significant modifications
were necessary.
This is based on top of #40