Skip to content

Fix reading rbsp_trailing_bits() #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamrial wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix reading rbsp_trailing_bits() #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e80f297
Fix reading rbsp_trailing_bits()
jamrial Feb 24, 2026
ae3ac86
Fix reading byte_alignment() in slice_header
jamrial Feb 24, 2026
1f7a2e7
Fix reading rbsp_slice_trailing_bits() in slice_layer_rbsp()
jamrial Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src_base/xevd.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1446,6 +1446,14 @@ int xevd_tile_eco(void * arg)
{
xevd_threadsafe_assign(&ctx->sync_row[core->y_lcu], THREAD_TERMINATED);
xevd_assert_gv(xevd_eco_tile_end_flag(bs, sbac) == 1, ret, XEVD_ERR, ERR);
u32 t0;
xevd_bsr_read1(bs, &t0);
xevd_assert_gv(1 == t0, ret, XEVD_ERR_MALFORMED_BITSTREAM, ERR);
while (!XEVD_BSR_IS_BYTE_ALIGN(bs))
{
xevd_bsr_read1(bs, &t0);
xevd_assert_gv(0 == t0, ret, XEVD_ERR_MALFORMED_BITSTREAM, ERR);
}
ret = xevd_eco_cabac_zero_word(bs);
xevd_assert_g(XEVD_SUCCEEDED(ret), ERR);
break;
Expand Down
12 changes: 12 additions & 0 deletions src_base/xevd_eco.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1382,6 +1382,7 @@ int xevd_eco_sps(XEVD_BSR * bs, XEVD_SPS * sps)
}

u32 t0;
xevd_bsr_read1(bs, &t0);
while (!XEVD_BSR_IS_BYTE_ALIGN(bs))
{
xevd_bsr_read1(bs, &t0);
Expand Down Expand Up @@ -1420,6 +1421,7 @@ int xevd_eco_pps(XEVD_BSR * bs, XEVD_SPS * sps, XEVD_PPS * pps)
}

u32 t0;
xevd_bsr_read1(bs, &t0);
while(!XEVD_BSR_IS_BYTE_ALIGN(bs))
{
xevd_bsr_read1(bs, &t0);
Expand Down Expand Up @@ -1567,6 +1569,8 @@ int xevd_eco_sh(XEVD_BSR * bs, XEVD_SPS * sps, XEVD_PPS * pps, XEVD_SH * sh, int

/* byte align */
u32 t0;
xevd_bsr_read1(bs, &t0);
xevd_assert_rv(1 == t0, XEVD_ERR_MALFORMED_BITSTREAM);
while(!XEVD_BSR_IS_BYTE_ALIGN(bs))
{
xevd_bsr_read1(bs, &t0);
Expand Down Expand Up @@ -1643,6 +1647,14 @@ int xevd_eco_sei(XEVD_CTX * ctx, XEVD_BSR * bs)
default:
xevd_assert_rv(0, XEVD_ERR_UNEXPECTED);
}

u32 t0;
xevd_bsr_read1(bs, &t0);
while (!XEVD_BSR_IS_BYTE_ALIGN(bs))
{
xevd_bsr_read1(bs, &t0);
}

#if TRACE_HLS
XEVD_TRACE_STR("************ SEI End ************\n");
XEVD_TRACE_STR("***********************************\n");
Expand Down
5 changes: 5 additions & 0 deletions src_main/xevdm_eco.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1992,6 +1992,7 @@ int xevdm_eco_sps(XEVD_BSR * bs, XEVD_SPS * sps)
if (sps->vui_parameters_present_flag)
xevd_eco_vui(bs, &(sps->vui_parameters));
u32 t0;
xevd_bsr_read1(bs, &t0);
while (!XEVD_BSR_IS_BYTE_ALIGN(bs))
{
xevd_bsr_read1(bs, &t0);
Expand Down Expand Up @@ -2069,6 +2070,7 @@ int xevdm_eco_pps(XEVD_BSR * bs, XEVD_SPS * sps, XEVD_PPS * pps)
pps->cu_qp_delta_area += 6;
}
u32 t0;
xevd_bsr_read1(bs, &t0);
while(!XEVD_BSR_IS_BYTE_ALIGN(bs))
{
xevd_bsr_read1(bs, &t0);
Expand Down Expand Up @@ -2126,6 +2128,7 @@ int xevdm_eco_aps_gen(XEVD_BSR * bs, XEVD_APS_GEN * aps, int bit_depth)
}
}

xevd_bsr_read1(bs, &t0);
while (!XEVD_BSR_IS_BYTE_ALIGN(bs))
{
xevd_bsr_read1(bs, &t0);
Expand Down Expand Up @@ -2796,6 +2799,8 @@ int xevdm_eco_sh(XEVD_BSR * bs, XEVD_SPS * sps, XEVD_PPS * pps, XEVD_SH * sh, XE

/* byte align */
u32 t0;
xevd_bsr_read1(bs, &t0);
xevd_assert_rv(1 == t0, XEVD_ERR_MALFORMED_BITSTREAM);
while(!XEVD_BSR_IS_BYTE_ALIGN(bs))
{
xevd_bsr_read1(bs, &t0);
Expand Down