Fix writing byte_alignment() in slice_header and rbsp_slice_trailing_bits() in slice_layer_rbsp()#160
Open
jamrial wants to merge 2 commits intompeg5:masterfrom
Open
Fix writing byte_alignment() in slice_header and rbsp_slice_trailing_bits() in slice_layer_rbsp()#160jamrial wants to merge 2 commits intompeg5:masterfrom
jamrial wants to merge 2 commits intompeg5:masterfrom
Conversation
Section 7.3.2.9 from ISO/IEC 23094-1:2020 states an alignment_bit_equal_to_one must be present before the zeroes that align to the next byte boundary. Signed-off-by: James Almer <jamrial@gmail.com>
Section 7.3.2.7 from ISO/IEC 23094-1:2020 states rbsp_trailing_bits() shall be present before any potential cabac_zero_word. Signed-off-by: James Almer <jamrial@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Section 7.3.2.9 from ISO/IEC 23094-1:2020 states an alignment_bit_equal_to_one must be present before the zeroes that align to the next byte boundary.
Section 7.3.2.7 from ISO/IEC 23094-1:2020 states rbsp_trailing_bits() shall be present before any potential cabac_zero_word.
This PR does not attempt to add a byte_alignment() in slice_data() as defined in Section 7.3.8.1 given that, as far as i could see, xeve does not yet support writing more than one tile.