Consume recovery job state in the tracking UI#3
Open
mprahl wants to merge 4 commits into
Open
Conversation
Signed-off-by: mprahl <mprahl@users.noreply.github.com>
56ad96e to
0d00768
Compare
Thread the persisted recovery fields through the job entities, protobufs, handlers, and backend tests so the server contract can land independently from the UI consumers. This keeps the recovery status and progress metadata reviewable as a wire-format and backend behavior change on top of the new schema. Signed-off-by: mprahl <mprahl@users.noreply.github.com>
0d00768 to
fd0f109
Compare
Teach the existing job-status hooks and scorer polling flows to understand NEEDS_RECOVERY, structured progress fields, and dedicated error messages once the backend contract is available. This keeps the main UI layer reviewable separately from the follow-up enum spelling fix. Signed-off-by: mprahl <mprahl@users.noreply.github.com>
Use the backend's CANCELED spelling in the shared tracking job hook so canceled-job checks line up with the actual AJAX response values. Signed-off-by: mprahl <mprahl@users.noreply.github.com>
f757513 to
9f72110
Compare
f5e197e to
591d4be
Compare
37f44a1 to
aed80e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 DevTools 🛠
Install mlflow from this PR
For Databricks, use the following command:
Related Issues/PRs
Recreates mlflow#22522
Relates to mlflow#22428
Relates to mlflow/rfcs#2
Blocked by #2
What changes are proposed in this pull request?
This PR splits the frontend consumer changes out of mlflow#22428 on top of mlflow#22521.
It updates the existing tracking job status hooks and scorer polling flows to treat
NEEDS_RECOVERYas in-flight, plumb the new progress and error metadata from the backend contract, and prefer the dedicatederror_messagefield for failure display. The final commit in this branch also renames the shared tracking hook's canceled enum spelling to match the API payloads.How is this PR tested?
Test commands:
yarn test --watch=false src/experiment-tracking/components/run-page/hooks/useFetchJobStatus.test.tsx src/experiment-tracking/pages/experiment-scorers/useEvaluateTracesAsync.test.tsx src/experiment-tracking/components/run-page/overview/IssueDetectionProgress.test.tsxDoes this PR require documentation update?
Does this PR require updating the MLflow Skills repository?
Release Notes
Is this a user-facing change?
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverHow should the PR be classified in the release notes? Choose one:
rn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionIs this PR a critical bugfix or security fix that should go into the next patch release?
What is a minor/patch release?
Minor releases are expected to contain larger changes, such as new features and improvements. Non-critical bug fixes and doc updates can be included as well. By default, your PR should target the next minor release.
Patch releases are typically only performed when there has been a major regression or bug in the latest release. For the sake of stability, your PR should not be included in a patch release unless it is a critical fix, or if the risk level of your PR is exceedingly low.