Skip to content

w32_common: force DWMWA_EXTENDED_FRAME_BOUNDS to work on init #17591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kasper93 merged 2 commits into from
Mar 17, 2026
+15 −1
Merged

w32_common: force DWMWA_EXTENDED_FRAME_BOUNDS to work on init #17591

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37c22c8
w32_common: add missing title bar height calc back
kasper93 Mar 16, 2026
93c397c
w32_common: force DWMWA_EXTENDED_FRAME_BOUNDS to work on init
kasper93 Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion video/out/w32_common.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,11 @@ static int get_title_bar_height(struct vo_w32_state *w32)
DwmGetWindowAttribute(w32->window, DWMWA_VISIBLE_FRAME_BORDER_THICKNESS,
&visible_border, sizeof(visible_border));
}
return visible_border;
int top_bar = IsMaximized(w32->window)
? get_system_metrics(w32, SM_CYFRAME) +
get_system_metrics(w32, SM_CXPADDEDBORDER)
: visible_border;
return top_bar;
}

static void add_window_borders(struct vo_w32_state *w32, HWND hwnd, RECT *rc)
Expand Down Expand Up @@ -1931,6 +1935,16 @@ static void window_resize(struct vo_w32_state *w32)
} else {
ShowWindow(w32->window, SW_SHOW);
}

// DWMWA_EXTENDED_FRAME_BOUNDS doesn't work when the window was not yet
// shown. We need it to correctly account for invisible window borders.
// Do one more forced resize after showing the window. This is only
// needed for Windows 10, but let's do the same for Windows 11 to get
// the same init behavior. In practice, this will only cause small
// adjustment to window position based on invisible borders, on
// Windows 11 it should be a no-op.
w32->pending_reset_size = true;
window_resize(w32);
}

finish:
Expand Down
Loading