fix: desktop integration enhancements#342
Merged
Merged
Conversation
The app already had the right icon, but Wayland desktops showed it pixelated: without the freedesktop desktop file name KWin cannot match the window to its installed entry, so the taskbar falls back to a rasterized copy instead of the scalable SVG. Set the desktop file name and a reverse-DNS app id so the match works. Look up the window icon by theme name too, so the task switcher also draws the scalable SVG instead of the upscaled bitmap Qt otherwise sends; fall back to the bundled file when the theme lookup misses. Also hand mpv the app name as its audio client name so the audio stream shows up labelled by the app instead of plain mpv.
The flatpak release build runs this recipe with UV_NO_PROJECT set, so uv already skips syncing. Passing --no-sync on top of that makes uv warn on every command. CI builds don't set UV_NO_PROJECT and still need --no-sync to avoid re-syncing the prepared virtualenv, so guard the export instead of dropping it.
4c70b81 to
ec176c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.