Update scheduled-validation.yml#19
Conversation
Add scheduled validation workflow with manual trigger Adds daily automated validation at 2 AM UTC with option to trigger manually. Includes input parameters for validation type and test configuration.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9d2b8012e0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Determine validation type | ||
| id: config | ||
| run: | | ||
| pip install --upgrade pip psycopg2-binary | ||
|
|
||
| - name: Apply schema | ||
| env: | ||
| PGPASSWORD: validation_password | ||
| run: | | ||
| psql -h localhost -U retail_admin -d retail_analytics_nightly -f schema/schema.sql -v ON_ERROR_STOP=1 | ||
|
|
||
| - name: Load sample data | ||
| env: | ||
| PGHOST: localhost | ||
| PGUSER: retail_admin | ||
| PGPASSWORD: validation_password | ||
| PGDATABASE: retail_analytics_nightly | ||
| run: | | ||
| python scripts/generate_data.py | ||
|
|
||
| - name: Run all queries | ||
| env: | ||
| PGPASSWORD: validation_password | ||
| run: | | ||
| for sql_file in queries/*.sql; do | ||
| echo "Running: $sql_file" | ||
| psql -h localhost -U retail_admin -d retail_analytics_nightly -f "$sql_file" | ||
| done | ||
| # When triggered by schedule, use 'full' validatio |
There was a problem hiding this comment.
The scheduled workflow now ends after a no-op “Determine validation type” step, so it never applies the schema, loads data, or runs any queries/tests. That means both the nightly schedule and manual dispatch will succeed without validating anything, which defeats the purpose of this workflow and can let regressions slip through unnoticed. If this is intentional, a separate validation job needs to be added; otherwise the removed steps need to be reinstated.
Useful? React with 👍 / 👎.
1 participant
Add scheduled validation workflow with manual trigger
Adds daily automated validation at 2 AM UTC with option to trigger manually. Includes input parameters for validation type and test configuration.