Detect changed Check constraint expressions in migrations#40
Merged
mr-fatalyst merged 1 commit intoJun 9, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #39
Fixes makemigrations not detecting changes to an existing Check constraint when the constraint name stays the same.
Before this change, the migration diff only compared check constraints by name, so this produced no migration:
Check("age >= 0", name="chk_users_age")when changed to:
Check("age > 0", name="chk_users_age")Now the diff detects same-name expression changes and emits:
The drop happens first because the replacement uses the same constraint name.
Reordered logic in crates/oxyde-migrate/src/diff.rs so changed same-name checks can be handled as drop_check then add_check.
Testing
cargo test -p oxyde-migrate --quiet
cargo test --workspace --exclude oxyde-core-py --quiet
uv run --project python --extra dev --no-sync pytest -q python/oxyde/tests/unit/test_migrations_execution.py