Add first-class enum support#41
Open
BiqRed wants to merge 1 commit into
Open
Conversation
Contributor
|
Added a PR BiqRed#1 to preserve enum type hints for joined queries and enum arrays |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds first-class support for string-valued Python enums across schema extraction, migrations, SQL rendering, and runtime value handling.
The migration layer now manages PostgreSQL enum types directly: it creates enum types before dependent tables, appends new enum values with ALTER TYPE, drops unused enum types, and emits a manual migration marker for destructive enum changes such as value removal or reorder. That keeps migration generation usable while making the unsafe step explicit in the generated file.
The query layer now keeps enum values typed as strings for binding, but adds PostgreSQL casts for enum columns and enum arrays. SQLite remains text-backed, while MySQL uses inline ENUM definitions in generated DDL.
Details
Testing