Include all packages in library list return value#40
Open
david-mears-2 wants to merge 4 commits intomainfrom
Open
Include all packages in library list return value#40david-mears-2 wants to merge 4 commits intomainfrom
david-mears-2 wants to merge 4 commits intomainfrom
Conversation
The /library/list endpoint now returns libraries installed anywhere, so we don't need to manually ensure at least one library has been installed
david-mears-2
changed the title
This was referenced Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the endpoint to report not only the list of R packages (with versions) installed in the shared library mounted at
/library, but instead report all installed packages alongside versions and locations.An alternative design would have been to report two lists, divided into 'those installed in the specified location (shared, additional packages)' and 'those installed elsewhere (core)'. I prefer reporting all locations, for increased generality; packit can do the logic that splits the list into two.
Don't merge this until the packit PR mrc-ide/packit#263 is ready to merge: packit currently expects to only be told about packages installed in the shared R library.