Address review feedback: error states, stable keys, permission alignment#260
Closed
Copilot wants to merge 3 commits intomrc-6905-show-installed-packagesfrom
Closed
Address review feedback: error states, stable keys, permission alignment#260Copilot wants to merge 3 commits intomrc-6905-show-installed-packagesfrom
Copilot wants to merge 3 commits intomrc-6905-show-installed-packagesfrom
Conversation
…on alignment, dev-start validation Co-authored-by: david-mears-2 <60350599+david-mears-2@users.noreply.github.com>
Co-authored-by: david-mears-2 <60350599+david-mears-2@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add R packages installed on runner page
Address review feedback: error states, stable keys, permission alignment
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses three review comments from #257.
PacketRunPackages: Destructure
isLoading/errorfromuseGetPackages()to render proper loading and error states instead of showing an infinite skeleton on fetch failure. Usepkg.nameas React key instead of array index.PacketRunnerLayout: Remove
hasGlobalPacketManagePermissiongate on the Packages sidebar link. Now visible to allpacket.runusers, aligning with the backend@PreAuthorize.scripts/dev-start: Validate
--r-lib-pathhas a following argument before consuming it.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.