fix: ignore Enter during IME composition#53
Open
greymoth-jp wants to merge 1 commit into
Open
Conversation
Pressing Enter to confirm an IME candidate (Japanese/Chinese/Korean input) sent the message early because the keydown handler did not check whether a composition was in progress. Add a !e.nativeEvent.isComposing guard so Enter only sends once composition has ended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typing Japanese, Chinese or Korean goes through an IME, where the first Enter confirms the current composition candidate rather than submitting. The keydown handler in
ChatBoxInputRowonly checkede.key === 'Enter' && messageContent, so that confirming Enter sent the message on a half-finished word.I added
!e.nativeEvent.isComposingto the send condition.nativeEventis the underlying DOMKeyboardEvent, which exposesisComposing; React's synthetic event type doesn't surface it directly, so reading it offnativeEventkeeps it type-safe.Repro: set the OS to a Japanese IME, type something like
かんじin the prompt box and press Enter to pick a kanji candidate.