WebGPURenderer: Fix XR shadows#34088
Merged
Merged
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
cabanier
force-pushed
the
webxr_shadow_transmission
branch
from
July 21, 2026 22:59
d759d8e to
d57884a
Compare
cabanier
commented
Jul 21, 2026
Contributor
Author
|
@Mugen87 if you prefer, I can split this in 2 PRs |
Collaborator
|
That would be great! |
Use the XR camera only for the output render target so offscreen shadow passes retain their light cameras. Guard XR foveation setup when no post-processing render target is required.
cabanier
force-pushed
the
webxr_shadow_transmission
branch
from
July 23, 2026 16:27
d57884a to
e2b9825
Compare
cabanier
changed the title
Contributor
Author
done |
cabanier
marked this pull request as ready for review
July 23, 2026 16:28
🖼️ E2E screenshot tests✅ All examples render correctly again (run). |
cabanier
marked this pull request as draft
July 23, 2026 16:55
cabanier
marked this pull request as ready for review
July 23, 2026 17:11
This comment was marked as resolved.
This comment was marked as resolved.
Mugen87
reviewed
Jul 24, 2026
Mugen87
reviewed
Jul 24, 2026
Refactor.
Collaborator
|
I've directly updated the branch with my feedback. Are you okay with the latest updates? |
Contributor
Author
yes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep XR camera substitution limited to the output target so offscreen shadow passes retain their own cameras, and tolerate a missing postprocessing target during XR setup.
Tested with both WebGPU and the WebGL fallback.
This contribution is funded by Meta