Skip to content

Addons: Fix typos.#34105

Merged
Mugen87 merged 2 commits into
mrdoob:devfrom
pailhead:fix-help-imports
Jul 24, 2026
Merged

Addons: Fix typos.#34105
Mugen87 merged 2 commits into
mrdoob:devfrom
pailhead:fix-help-imports

Conversation

@pailhead

@pailhead pailhead commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Fixed #34106

Description

Someone reported an issue with the help docs. I found the same typo in these three classes.

This contribution is funded by @paihead

@pailhead

pailhead commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

I didn't realize these are auto generated. Do i just need to change the comment?

I'm not sure how this e2e broke, i only changed the comments.

@github-actions

Copy link
Copy Markdown

🖼️ E2E screenshot tests

1 example(s) failed (full artifacts).

Example Expected Actual Diff
webgpu_pmrem_cubemap

@Mugen87 Mugen87 added this to the r186 milestone Jul 24, 2026
@Mugen87
Mugen87 merged commit 26de4f2 into mrdoob:dev Jul 24, 2026
8 of 9 checks passed
@Mugen87 Mugen87 changed the title fix typos Addons: Fix typos. Jul 24, 2026
@pailhead

Copy link
Copy Markdown
Contributor Author

@Mugen87 is there something wrong with this visual regression test? Why did this trigger it?

@Mugen87

Mugen87 commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

#33559

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BoxLineGeometry, ParametricGeometry and RoundedBoxGeometry have wrong constructor signatures in the docs

2 participants