fix: resolve 3 workflow automation bugs causing daily CI failures#27
Merged
mrjasonroy merged 1 commit intomainfrom Feb 20, 2026
Merged
fix: resolve 3 workflow automation bugs causing daily CI failures#27mrjasonroy merged 1 commit intomainfrom
mrjasonroy merged 1 commit intomainfrom
Conversation
1. Strip semver range prefix in version comparison (nextjs-version-check) - `require().dependencies.next` returns "^16.1.6" but npm view returns "16.1.6" - The caret prefix made the comparison always report "update needed" - Fix: strip non-numeric prefix before comparing 2. Replace Docker Compose with service containers (nextjs-version-check, catch-up-release) - `docker compose up -d && sleep 5` is fragile and caused Redis connection errors - `docker exec nextjs-cache-redis` references a container name that doesn't exist in CI - Fix: use GitHub Actions service containers with health checks, matching ci.yml pattern 3. Remove double-trigger in publish.yml - Triggered on both `push: tags` and `release: published` - Tag push runs the workflow, which creates a GitHub release at the end - That release re-triggers the workflow, which fails on duplicate npm publish - Fix: remove `release: published` trigger; tag push is sufficient Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke and why
Bug 1: Semver caret prefix caused false 'update needed' every day
require().dependencies.nextreturns^16.1.6butnpm view next versionreturns16.1.6. String comparison always evaluated totrue, creating a new branch and running tests daily even when already on the latest version.Fix: Strip non-numeric prefix before comparing (
.replace(/^[^0-9]*/, '')).Bug 2: Docker Compose Redis setup failed in version-check workflow
The workflow used
docker compose up -d && sleep 5which is fragile — Redis wasn't ready in time, causing blank[Redis] Error:connection failures. Also hardcodeddocker exec nextjs-cache-rediswhich doesn't exist in the CI environment.Fix: Replaced with GitHub Actions service containers (same pattern as
ci.yml), with proper health checks. Updated Redis flush to useredis-cli -h localhost FLUSHALL.Same fix applied to
catch-up-release.yml.Bug 3: Double-publish in publish.yml
publish.ymltriggered on bothpush: tagsandrelease: published. The tag-push run creates a GitHub release at the end (gh release create), which re-triggers the workflow — second run fails with npm error 'version already published'.Fix: Removed
release: publishedtrigger. Tag push alone is sufficient.Analysis and fix by Iris + Claude Code