Add solution for ::replace and ::search methods#1
Open
mrjoshua22 wants to merge 3 commits intomainfrom
Open
Conversation
YJorge
reviewed
Jul 10, 2025
test/exercise/arrays/solution.rb
Outdated
| def search(_array, _query) | ||
| 0 | ||
| def search(array, query, low = 0, high = array.size - 1) | ||
| return -1 if low > high |
There was a problem hiding this comment.
Давай тут же сразу проверим не только что мы ничего не нашли в конце поиска, но и то имеет ли нам смысл вообще что то искать дальше.
Мы знаем что массив отсортирован, и что в начале у него самое маленькое значение, а в конце самое большое. (Что в т.ч. справедливо и для любого подмассива).
Т.е. мы можем проверить входит ли то число которое мы ищем в рамки того массива(или подмассива) в котором мы собираемся искать.
Owner
Author
There was a problem hiding this comment.
Ок, добавил. В первоначальном варианте была такая проверка, но посчитал излишней раз при отсутствии числа в массиве / подмассиве все равно в итоге придет к пустому массиву и возврату -1.
YJorge
approved these changes
Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.