Skip to content

chore: migrate workflow helper scripts for #320 phase B#324

Merged
mrlunchbox777 merged 4 commits intomainfrom
feature/bsctl-script-path-migration-320
Apr 9, 2026
Merged

chore: migrate workflow helper scripts for #320 phase B#324
mrlunchbox777 merged 4 commits intomainfrom
feature/bsctl-script-path-migration-320

Conversation

@mrlunchbox777
Copy link
Copy Markdown
Owner

Summary

  • move workflow helper scripts from bsctl/scripts/workflows/ to scripts/workflows/
  • update workflow call sites and path filters to the new script location (docs-bump, dependabot-autobump, action-validator, agents-validate)
  • update pivot: decommission bsctl Go CLI and retire CodeQL #320 decommission planning doc and bump version/changelog to reflect Phase B script-path migration

Validation

  • ran ./scripts/workflows/docs-bump_docs-bump_version-bump.sh
  • ran ./scripts/workflows/docs-bump_docs-bump_CHANGELOG-bump.sh
  • ran ./scripts/workflows/agents-validate_agents-instructions-check.sh
  • attempted ./scripts/workflows/action-validator_check-actions_lint-actions.sh (requires action-validator installed in CI)

Issue Link

@github-actions github-actions Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. changes/documentation Documentation file changes changes/root Root file changes changes/meta .github file changes changes/resources Resources file changes labels Apr 9, 2026
@mrlunchbox777 mrlunchbox777 added kind/chore Chore to be completed, e.g. renovate priority/4 Lower priority status/doing Being worked labels Apr 9, 2026
@mrlunchbox777
Copy link
Copy Markdown
Owner Author

Phase B kickoff complete for #320.

  • Migrated workflow helper scripts to scripts/workflows/ and updated workflow call sites.
  • Synced managed labels with issue pivot: decommission bsctl Go CLI and retire CodeQL #320 (kind/chore, priority/4, status/doing, and changes labels).
  • Validation run locally for docs-bump and agents-validate scripts; action-validator remains CI-only due tool install dependency.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR continues the #320 Phase B migration by relocating workflow helper scripts from the legacy bsctl/ subtree into scripts/workflows/, updating workflow call sites/path filters, and bumping version/changelog to reflect the completed script-path move.

Changes:

  • Added migrated workflow helper scripts under scripts/workflows/ (docs-bump, dependabot-autobump, action-validator, agents-validate).
  • Updated GitHub workflow call sites/path filters to use the new scripts/workflows/* locations.
  • Updated planning docs plus version/changelog (including legacy constants mirroring) for the Phase B milestone.

Reviewed changes

Copilot reviewed 9 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
scripts/workflows/docs-bump_docs-bump_version-bump.sh New location for version divergence check script used by docs-bump workflow.
scripts/workflows/docs-bump_docs-bump_CHANGELOG-bump.sh New location for changelog validation script used by docs-bump workflow.
scripts/workflows/dependabot-autobump_bump-version.sh New location for Dependabot patch bump script.
scripts/workflows/dependabot-autobump_update-changelog.sh New location for Dependabot changelog update script.
scripts/workflows/agents-validate_agents-instructions-check.sh New location for agent instructions/skills validation script.
scripts/workflows/action-validator_check-actions_lint-actions.sh New location for action-validator helper script.
.github/workflows/docs-bump.yaml Updated to run docs-bump helper scripts from scripts/workflows/.
.github/workflows/dependabot-autobump.yaml Updated to run dependabot helper scripts from scripts/workflows/.
.github/workflows/agents-validate.yaml Updated path filters and run step to the new agents-validate script location.
.github/workflows/action-validator.yaml Updated to run action-validator helper script from scripts/workflows/.
resources/version.yaml Bumped primary version source to 0.1.22.
bsctl/static/resources/constants.yaml Mirrored legacy version bump to 0.1.22.
CHANGELOG.md Added 0.1.22 entry describing Phase B script-path migration.
docs/plans/bsctl-codeql-decommission-plan.md Updated Phase B plan text and workflow/script references to new paths.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/docs-bump.yaml
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 14 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 15 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

scripts/workflows/action-validator_check-actions_lint-actions.sh:5

  • This pipeline relies on grep/xargs but the script doesn’t enable set -euo pipefail, so failures in earlier pipeline stages can be ignored. Consider adding strict mode (and optionally xargs -r on GNU systems) so the workflow fails deterministically when no files are found or a command errors.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mrlunchbox777 mrlunchbox777 merged commit a113aa8 into main Apr 9, 2026
13 checks passed
@mrlunchbox777 mrlunchbox777 deleted the feature/bsctl-script-path-migration-320 branch April 9, 2026 04:04
@mrlunchbox777 mrlunchbox777 added status/review Ready for review and removed status/doing Being worked labels Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes/documentation Documentation file changes changes/meta .github file changes changes/resources Resources file changes changes/root Root file changes kind/chore Chore to be completed, e.g. renovate priority/4 Lower priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/review Ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pivot: decommission bsctl Go CLI and retire CodeQL

2 participants