chore: migrate workflow helper scripts for #320 phase B#324
chore: migrate workflow helper scripts for #320 phase B#324mrlunchbox777 merged 4 commits intomainfrom
Conversation
|
Phase B kickoff complete for #320.
|
There was a problem hiding this comment.
Pull request overview
This PR continues the #320 Phase B migration by relocating workflow helper scripts from the legacy bsctl/ subtree into scripts/workflows/, updating workflow call sites/path filters, and bumping version/changelog to reflect the completed script-path move.
Changes:
- Added migrated workflow helper scripts under
scripts/workflows/(docs-bump, dependabot-autobump, action-validator, agents-validate). - Updated GitHub workflow call sites/path filters to use the new
scripts/workflows/*locations. - Updated planning docs plus version/changelog (including legacy constants mirroring) for the Phase B milestone.
Reviewed changes
Copilot reviewed 9 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/workflows/docs-bump_docs-bump_version-bump.sh | New location for version divergence check script used by docs-bump workflow. |
| scripts/workflows/docs-bump_docs-bump_CHANGELOG-bump.sh | New location for changelog validation script used by docs-bump workflow. |
| scripts/workflows/dependabot-autobump_bump-version.sh | New location for Dependabot patch bump script. |
| scripts/workflows/dependabot-autobump_update-changelog.sh | New location for Dependabot changelog update script. |
| scripts/workflows/agents-validate_agents-instructions-check.sh | New location for agent instructions/skills validation script. |
| scripts/workflows/action-validator_check-actions_lint-actions.sh | New location for action-validator helper script. |
| .github/workflows/docs-bump.yaml | Updated to run docs-bump helper scripts from scripts/workflows/. |
| .github/workflows/dependabot-autobump.yaml | Updated to run dependabot helper scripts from scripts/workflows/. |
| .github/workflows/agents-validate.yaml | Updated path filters and run step to the new agents-validate script location. |
| .github/workflows/action-validator.yaml | Updated to run action-validator helper script from scripts/workflows/. |
| resources/version.yaml | Bumped primary version source to 0.1.22. |
| bsctl/static/resources/constants.yaml | Mirrored legacy version bump to 0.1.22. |
| CHANGELOG.md | Added 0.1.22 entry describing Phase B script-path migration. |
| docs/plans/bsctl-codeql-decommission-plan.md | Updated Phase B plan text and workflow/script references to new paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 14 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 15 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
scripts/workflows/action-validator_check-actions_lint-actions.sh:5
- This pipeline relies on
grep/xargsbut the script doesn’t enableset -euo pipefail, so failures in earlier pipeline stages can be ignored. Consider adding strict mode (and optionallyxargs -ron GNU systems) so the workflow fails deterministically when no files are found or a command errors.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
bsctl/scripts/workflows/toscripts/workflows/docs-bump,dependabot-autobump,action-validator,agents-validate)Validation
./scripts/workflows/docs-bump_docs-bump_version-bump.sh./scripts/workflows/docs-bump_docs-bump_CHANGELOG-bump.sh./scripts/workflows/agents-validate_agents-instructions-check.sh./scripts/workflows/action-validator_check-actions_lint-actions.sh(requiresaction-validatorinstalled in CI)Issue Link