Conversation
Author
|
@mroderick some attention please |
|
@mroderick same to me |
|
Is there something we can help with to get this merged? Maybe removing https://github.com/mroderick/PubSubJS/blob/master/README.md?plain=1#L217 I added a comment on the PR that introduced Symbol support: #141 (comment) |
Owner
|
This looks good to me. Is there anything you'd add/change @verekia ? |
|
Looks good to me too :) |
|
Any news here? Are you going to release it anytime soon? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Symbol message is converted to string, this behavior make uselles using symbols. Because symbols are not strings, and every symbol is unique
Symbol("message") !== Symbol("message").What is the purpose of this pull request?
Reproduction
Next code will call
func1twice. This is unexpecte behavior,func1must be called only once.