Open
Conversation
Author
Open
|
This feels like it's going in the opposite direction to the one that I mentally hold between library and support-library. I Could definitely see an argument for the @types/pubsub-js being bundled in a [separate] meta-package, or itself at least suggesting use of PubSubJS. This patch, feels like it would at-least conceptually make this library dependent on some user-supplied types (which may or may not be accurate) and are not under control of the author(s) of this library (support-library). Are there other examples of npm libraries that bundle @types? I know Jest at least seems to require separate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a hard dependency on @types/pubsub-js, so that any user who installs the main lib automatically gets the types.
Package managers do not install devDependencies when you install a library. They install just dependencies (and in the case of NPM 7, peerDependencies as well, although that's a separate topic).