Skip to content

feat: Add support for Harness web#1032

Open
riteshshukla04 wants to merge 9 commits into
mrousavy:mainfrom
riteshshukla04:main
Open

feat: Add support for Harness web#1032
riteshshukla04 wants to merge 9 commits into
mrousavy:mainfrom
riteshshukla04:main

Conversation

@riteshshukla04
Copy link
Copy Markdown
Contributor

feat: Add support for Harness web

Copy link
Copy Markdown
Owner

@mrousavy mrousavy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is a good direction, but I have two blockers before merging:

  1. My comment about nativeOnly tests
  2. The patch. With a patch, this can't go into main. Create an upstream PR in Harness / RN for this, talk to Szymon Chmal or Hanno about this

Comment thread example/__tests__/MMKV.harness.ts Outdated
Comment thread example/patches/harness-web-support.patch Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants