feat: Properly report YUV range (-full or -video) on Android#4034
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mrousavy
changed the title
'yuv-444-8-bit-full'-full or -video) on Android
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we just assumed all YUV buffers on Android are in
-fullrange (e.g.yuv-420-8-bit-full).This is wrong, since it technically can be a different range (like
-video), but that wasn't encoded in theImageProxy.formatenum, so we had no way of telling.Turns out, there is
DataSpacewhich tells us stuff like transfer function, or pixel range.So now with this PR we use that - and actually tell the user if a Frame is in full or video range.