feat: Add support for passing declarative position to Camera Device configuration#4057
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
* fix: Resolve connections upfront * WIP * ughhhh * rename * Resolve for input * Update HybridCameraSession.swift * Restructure ResolvedCameraSessionConnection to map 1:1 * uhm? * Update HybridCameraController.swift * it builds * custom config type ig * Move out * extract * chore: Lint * remove dead code * impl android hihi * Update ResolvableConstraint+AVAutoFocusSystem.swift * Update CameraSessionConnection+getCameraInfo.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds native support to passing a
CameraPositiontosession.configure([{ input: ..., ... }]).This allows skipping
CameraDeviceFactoryentirely, and avoids a race condition where the devices haven't loaded yet but the user wants to display a Camera via the declarative API (so notuseCameraDevice(...)).