You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Implements #250 — resolves the IsPackable conflict for Ploch.Common.WebUI by deciding yes, the project ships as a NuGet package (the decision requested by the issue, confirmed with the repo owner as part of the v4.0 pre-release batch).
Changes
Added <IsPackable>true</IsPackable> to Ploch.Common.WebUI.csproj (with a comment explaining the Microsoft.NET.Sdk.Web default it overrides).
Added a change-log entry — a new package shipping is a user-visible change for the v4.0 release notes.
Package metadata verified by unpacking the produced .nupkg: id, authors, Apache-2.0 licence, README, SourceLink repository commit, dependency group and Microsoft.AspNetCore.App framework reference all render correctly.
Testing
Ploch.Common.WebUI.4.0.9-prerelease.*.nupkg produced on build; nuspec inspected and correct.
Full solution build: zero warnings — first fully-clean build (this was the last remaining warning).
Full test suite: all 15 test assemblies pass, 0 failures.
Microsoft.NET.Sdk.Web defaults IsPackable to false, while the repo-level
Directory.Build.props sets GeneratePackageOnBuild for all non-test
projects. The conflict emitted a pack warning on every solution build and
silently prevented the package from being produced, despite the project's
clear packaging intent (PackageReadmeFile + packed README).
Explicitly enable IsPackable so Ploch.Common.WebUI (AppPage,
SelectListHelper and related Razor/MVC page utilities) ships alongside
the other Ploch.* packages. Verified the produced package metadata:
readme, licence, SourceLink repository commit and dependencies all render
correctly. The full solution now builds with zero warnings.
Refs: #250
🤖 Review skipped: Repository Owner rate limit exceeded. Free accounts are limited to 3 reviews per 4 hours across all repositories. Upgrade to a paid plan for unlimited reviews.
🧙 Sourcery has finished reviewing your pull request!
Tips and commands
Interacting with Sourcery
Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment @sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment @sourcery-ai review to trigger a new review!
@kploch, you've reached your PR review limit, so we couldn't start this review.
Next review available in:34 minutes
Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).
How can I continue?
After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.
To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.
How do review limits work?
CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.
For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
We reviewed changes in 5f324e1...da06543 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Enables NuGet packaging for Ploch.Common.WebUI by explicitly overriding Microsoft.NET.Sdk.Web’s default IsPackable=false, aligning the project’s build behavior with its existing packaging intent and repository-wide GeneratePackageOnBuild configuration.
Changes:
Set <IsPackable>true</IsPackable> in src/Common.WebUI/Ploch.Common.WebUI.csproj to eliminate the recurring pack warning and ensure the package is produced.
Added a change-log entry documenting that Ploch.Common.WebUI now ships as a NuGet package and that the pack warning is resolved.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File
Description
src/Common.WebUI/Ploch.Common.WebUI.csproj
Explicitly enables packing for the Web SDK project to resolve the IsPackable conflict and produce a NuGet package.
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
The PR successfully enables NuGet packaging for the Ploch.Common.WebUI library, resolving build warnings and providing the required changelog documentation. Automated quality checks indicate the project remains up to standards. However, the implementation reveals that the project currently uses the Web SDK (Microsoft.NET.Sdk.Web) for what is effectively a library (OutputType Library). Switching to the Razor SDK would be more idiomatic for this use case and would enable packaging by default without explicit property overrides.
Test suggestions
Verify that IsPackable is explicitly set to true in the .csproj file
Verify that the project build no longer produces packaging-related warnings
Verify the presence of a changelog entry documenting the transition to a NuGet package
🤖 Review skipped: Repository Owner rate limit exceeded. Free accounts are limited to 3 reviews per 4 hours across all repositories. Upgrade to a paid plan for unlimited reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
Summary
Implements #250 — resolves the
IsPackableconflict forPloch.Common.WebUIby deciding yes, the project ships as a NuGet package (the decision requested by the issue, confirmed with the repo owner as part of the v4.0 pre-release batch).Changes
<IsPackable>true</IsPackable>toPloch.Common.WebUI.csproj(with a comment explaining theMicrosoft.NET.Sdk.Webdefault it overrides).Design Decisions
PackageReadmeFile, README packed) and contains shipped utility code (AppPage,SelectListHelper— the latter just bug-fixed in Harden pre-existing edge cases in JoinWithFinalSeparator and SelectListHelper #248/PR fix(common): Harden JoinWithFinalSeparator and SelectListHelper edge cases #255). The docs (docs/libraries/common-webui.md) already instructdotnet add package Ploch.Common.WebUI; this makes that instruction true..nupkg: id, authors, Apache-2.0 licence, README, SourceLink repository commit, dependency group andMicrosoft.AspNetCore.Appframework reference all render correctly.Testing
Ploch.Common.WebUI.4.0.9-prerelease.*.nupkgproduced on build; nuspec inspected and correct.Related
Closes #250
Summary by Sourcery
Enable NuGet packaging for Ploch.Common.WebUI and document the change in the release change-log.
New Features:
Bug Fixes:
Documentation: