Skip to content

docs: update checklist#4

Merged
Pertempto merged 2 commits intomainfrom
install-agent-skills
Feb 27, 2026
Merged

docs: update checklist#4
Pertempto merged 2 commits intomainfrom
install-agent-skills

Conversation

@Pertempto
Copy link
Copy Markdown
Contributor

@Pertempto Pertempto commented Feb 24, 2026

No description provided.

Added installation step for agent skills repository.

Signed-off-by: Addison Emig <addison.emig@mrs-electronics.com>
@Pertempto Pertempto self-assigned this Feb 24, 2026
@Pertempto Pertempto requested a review from bambam955 February 24, 2026 13:48
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 24, 2026

Code Review: PR #4

PR Title

Correct format - The title docs: update checklist follows the conventional commit style with the type docs and a description. The scope portion is not required.

Changes Overview

  • 4 files changed, +31 additions, 0 deletions

Review

.pre-commit-config.yaml (new file)

✅ Good addition. The pre-commit hooks configuration is appropriate for a docs project:

  • trailing-whitespace - prevents trailing whitespace
  • end-of-file-fixer - ensures files end with newline
  • check-yaml - validates YAML syntax
  • check-added-large-files - prevents accidental large file commits

Consider adding pretty-format-json if JSON files are commonly edited in this project.

README.md

✅ Good change. Adding a checklist item for installing the agent-skills repo is appropriate for documentation setup.

justfile (new file)

✅ Good addition. The justfile provides convenient commands:

  • deps - installs npm dependencies
  • setup - runs pre-commit install
  • dev - runs the development server

This is a nice developer experience improvement.

package-lock.json

⚠️ Note: The changes to package-lock.json (adding "peer": true to several packages) appear to be an artifact of npm's behavior rather than an intentional change. This is harmless but could be reconsidered—peer dependencies are typically declared in package.json, not package-lock.json.

If this was unintentional, you may want to regenerate the lockfile with npm install to get a cleaner diff.

Summary

The PR is well-structured and adds useful tooling for the docs template. The changes are appropriate for setting up a new docs repository with pre-commit hooks and development scripts.

Recommendation: Approve, with a note to clarify the package-lock.json changes if they were unintended.


🔗 OpenCode Session

@Pertempto Pertempto changed the title docs: mention agent skills docs: mention agent skills and justfile Feb 24, 2026
Comment thread README.md
@Pertempto Pertempto changed the title docs: mention agent skills and justfile docs: update checklist Feb 24, 2026
@Pertempto Pertempto requested a review from bambam955 February 27, 2026 17:20
@Pertempto Pertempto merged commit c687098 into main Feb 27, 2026
1 check passed
@Pertempto Pertempto deleted the install-agent-skills branch February 27, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants