Skip to content

chore: add lint and format config#5

Merged
Pertempto merged 4 commits intomainfrom
1-add-lint-format-config
Mar 24, 2026
Merged

chore: add lint and format config#5
Pertempto merged 4 commits intomainfrom
1-add-lint-format-config

Conversation

@Pertempto
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions
Copy link
Copy Markdown

Code Review: PR #5 - chore: add lint and format config

PR Title ✓

The title chore: add lint and format config follows the conventional commit style correctly. Type chore is valid and the description is clear.

Changes Overview

This PR adds ESLint, Prettier, and GitHub Actions workflow for lint/format checking. Good addition of tooling.

Suggestions

1. astro.config.mjs formatting changes (lines 89-144 in diff)

The changes to astro.config.mjs are purely formatting (2-space indentation instead of tabs, double quotes instead of single quotes). This creates significant diff noise and makes the PR harder to review.

Consider:

  • Keeping formatting changes minimal in future PRs
  • Or explaining why the formatting was changed (e.g., matching project style)

2. Good practices observed:

  • New .prettierignore properly excludes build artifacts
  • GitHub Actions workflow triggers on appropriate file types
  • Pre-commit hooks configured for both ESLint and Prettier
  • Package.json includes both lint and format scripts
  • Justfile updated with convenience commands

Verdict

Approve - The lint and format infrastructure is well-configured. The only note is the formatting changes in astro.config.mjs which could have been kept minimal, but this doesn't block merge.


🔗 OpenCode Session

@Pertempto Pertempto merged commit 41a946b into main Mar 24, 2026
2 checks passed
@Pertempto Pertempto deleted the 1-add-lint-format-config branch March 24, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant