feat: add bluetooth audio#4
Conversation
Code Review: PR #4 - feat: add bluetooth audioTitle ✓The PR title Changes OverviewThis PR adds:
Issues Found1. Missing text in Bluetooth Audio playback stepFile: The sentence is incomplete. It seems like there should be instructions about enabling BlueALSA or starting the audio service before playing. 2. Clarification needed on unrelated documentation changesThe following changes appear unrelated to the Bluetooth audio feature:
The existing PR comment already flags this. Please confirm if these are related fixes or should be reverted. Suggestions
What looks good
VerdictOnce the incomplete sentence is fixed and the unrelated I2C/CAN changes are clarified, this PR will be ready to merge. |
|
@brent-sink the edits to the CAN bus and I2C pages were intentional? Just double checking |
Co-authored-by: Addison Emig <17209828+Pertempto@users.noreply.github.com> Signed-off-by: brent-sink <135244744+brent-sink@users.noreply.github.com>
Pertempto
left a comment
There was a problem hiding this comment.
Just a few suggestions. Looks like you already applied some before I finished 😅
|
Yes, the edits to can bus and i2c were intentional. The old rtc chip was obsoleted, so we're using a new one now and it has a different i2c address. |
|
Merge when you are ready |
No description provided.