Skip to content

feat: add bluetooth audio#4

Merged
brent-sink merged 26 commits intomainfrom
add-bluetooth-audio
Mar 5, 2026
Merged

feat: add bluetooth audio#4
brent-sink merged 26 commits intomainfrom
add-bluetooth-audio

Conversation

@brent-sink
Copy link
Copy Markdown
Contributor

No description provided.

@brent-sink brent-sink requested a review from Pertempto March 5, 2026 17:15
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 5, 2026

Code Review: PR #4 - feat: add bluetooth audio

Title ✓

The PR title feat: add bluetooth audio follows the conventional commit format correctly. Good job.


Changes Overview

This PR adds:

  • Bluetooth audio documentation and configuration
  • New pre-commit config and justfile for developer experience
  • Minor fixes to I2C and CAN bus documentation

Issues Found

1. Missing text in Bluetooth Audio playback step

File: src/content/docs/operating-system/multimedia.mdx:259-260

Before you can play audio from your phone, you will need to enable 
Play an audio file on your phone, and will be streamed to the `bt-sink` profile in ALSA.

The sentence is incomplete. It seems like there should be instructions about enabling BlueALSA or starting the audio service before playing.

2. Clarification needed on unrelated documentation changes

The following changes appear unrelated to the Bluetooth audio feature:

  • I2C.mdx (line 151): Changed RTC address from 0x68 to 0x51 — was this intentional?
  • can-bus.mdx (lines 165-166): Changed CAN baud rate update command from spidev_test to vip can-baud — was this intentional?

The existing PR comment already flags this. Please confirm if these are related fixes or should be reverted.


Suggestions

  1. Complete the incomplete sentence in the "Play Audio" section
  2. Consider splitting unrelated changes (I2C and CAN bus fixes) into separate PRs for clarity

What looks good

  • Comprehensive Bluetooth pairing instructions in connectivity.mdx
  • Well-structured step-by-step guides using the <Steps> component
  • Added ALSA configuration for Bluetooth sink (bt-sink)
  • New developer tooling files (pre-commit, justfile)

Verdict

Once the incomplete sentence is fixed and the unrelated I2C/CAN changes are clarified, this PR will be ready to merge.


🔗 OpenCode Session

@Pertempto Pertempto changed the title feat: Add bluetooth audio feat: add bluetooth audio Mar 5, 2026
@Pertempto
Copy link
Copy Markdown
Contributor

@brent-sink the edits to the CAN bus and I2C pages were intentional? Just double checking

Comment thread src/content/docs/hardware/connectivity.mdx Outdated
Comment thread src/content/docs/hardware/connectivity.mdx Outdated
Comment thread src/content/docs/hardware/connectivity.mdx Outdated
Co-authored-by: Addison Emig <17209828+Pertempto@users.noreply.github.com>
Signed-off-by: brent-sink <135244744+brent-sink@users.noreply.github.com>
Comment thread src/content/docs/hardware/connectivity.mdx
Comment thread src/content/docs/operating-system/multimedia.mdx Outdated
Copy link
Copy Markdown
Contributor

@Pertempto Pertempto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions. Looks like you already applied some before I finished 😅

@brent-sink
Copy link
Copy Markdown
Contributor Author

Yes, the edits to can bus and i2c were intentional. The old rtc chip was obsoleted, so we're using a new one now and it has a different i2c address.

@Pertempto
Copy link
Copy Markdown
Contributor

Merge when you are ready

@brent-sink brent-sink merged commit 06de001 into main Mar 5, 2026
1 check passed
@brent-sink brent-sink deleted the add-bluetooth-audio branch March 5, 2026 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants