fix(ci): make Code Quality workflow fully green (#2128)#2164
Open
mrveiss wants to merge 4 commits intoDev_new_guifrom
Open
fix(ci): make Code Quality workflow fully green (#2128)#2164mrveiss wants to merge 4 commits intoDev_new_guifrom
mrveiss wants to merge 4 commits intoDev_new_guifrom
Conversation
- Update pre-commit: Black 23.12.1→26.3.1, isort 5.13.2→8.0.1, flake8 7.0.0→7.3.0, autoflake 2.2.1→2.3.3 - Pin CI workflow to exact same versions to prevent drift
Mechanical reformatting — no logic changes. These files were never formatted by Black because pre-commit only runs on staged files. CI checks all files, causing persistent failures (200+ files).
- Exclude migration dirs from function-length hook (inherently long) - Exclude ansible-deployed dirs from no-print-console hook (doctest examples) - Format remaining files that were blocked by these false positives
✅ SSOT Configuration Compliance: Passing🎉 No hardcoded values detected that have SSOT config equivalents! |
Owner
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. Reviewed: version pinning, .flake8/.bandit config alignment, 3 global declaration removals (all read-only — safe), hook exclusion patterns, and bulk formatting scope. All changes are correct and consistent. Minor observations (below reporting threshold, not blocking):
🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Code Quality CI workflow has never passed (62 failures, 0 successes across 100 runs). Three root causes:
.flake8/.banditconfig files that pre-commit uses.Changes
.flake8config instead of mismatched inline argsglobalkeyword)Local verification (all exit 0)
black --checkisort --checkflake8 --config=.flake8autoflake --checkbandit -c .banditTest plan
Closes #2128