fix(chat): stop silently swallowing exceptions in load_session (#1906)#2176
Merged
mrveiss merged 2 commits intoDev_new_guifrom Mar 24, 2026
Merged
fix(chat): stop silently swallowing exceptions in load_session (#1906)#2176mrveiss merged 2 commits intoDev_new_guifrom
mrveiss merged 2 commits intoDev_new_guifrom
Conversation
Remove bare except-all blocks from SessionMixin.load_session and ChatHistoryManager.load_session. FileNotFoundError, PermissionError, and ValueError now propagate to callers which already have proper handlers (added in #1797).
✅ SSOT Configuration Compliance: Passing🎉 No hardcoded values detected that have SSOT config equivalents! |
- Remove inaccurate FileNotFoundError from session.py docstring - Add exception handling to get_messages and get_session_message_count which were unprotected callers of load_session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
except Exceptionblocks fromSessionMixin.load_sessionandChatHistoryManager.load_sessionFileNotFoundError,PermissionError, andValueErrornow propagate to callerschat.pyalready has proper handlers for these exceptions (added in feat: Add timeout + granular error mapping to chat message processing #1797)[](not an error)Test plan
[]without raising🤖 Generated with Claude Code