fix(orchestration): wire WorkflowExecutor into scheduler startup (#2166)#2201
Merged
mrveiss merged 1 commit intoDev_new_guifrom Mar 23, 2026
Merged
fix(orchestration): wire WorkflowExecutor into scheduler startup (#2166)#2201mrveiss merged 1 commit intoDev_new_guifrom
mrveiss merged 1 commit intoDev_new_guifrom
Conversation
Add _wire_scheduler_executor() to Phase 2 background init that: - Creates EnhancedOrchestrator and adapter function - Routes template workflows to _default_template_executor (unchanged) - Routes non-template workflows through full orchestration pipeline - Calls workflow_scheduler.set_workflow_executor() at startup - Gracefully falls back to template-only if wiring fails
✅ SSOT Configuration Compliance: Passing🎉 No hardcoded values detected that have SSOT config equivalents! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WorkflowScheduler.set_workflow_executor()was defined but never called from startup code. Non-template scheduled workflows silently failed with{"success": False, "error": "No template_id"}.Adds
_wire_scheduler_executor()to Phase 2 background init ininitialization/lifespan.pythat:EnhancedOrchestratorinstanceworkflow_scheduler.set_workflow_executor()at startupChanges
initialization/lifespan.py: New_wire_scheduler_executor()function + call ininitialize_background_services()Test plan
[ 98%] Scheduler: Orchestration executor wiredin logs)user_messagebut notemplate_id) — should now execute via EnhancedOrchestrator instead of silently failingCloses #2166