fix(slm): add tablename collision check for dual SQLAlchemy bases (#1878)#2205
Open
mrveiss wants to merge 1 commit intoDev_new_guifrom
Open
fix(slm): add tablename collision check for dual SQLAlchemy bases (#1878)#2205mrveiss wants to merge 1 commit intoDev_new_guifrom
mrveiss wants to merge 1 commit intoDev_new_guifrom
Conversation
) Add _check_tablename_collisions() startup check that detects shared tablenames across both SQLAlchemy Base MetaData objects. Logs WARNING for overlaps to catch misplacement bugs early (like #1854). Does not raise since some names are intentionally shared across databases.
✅ SSOT Configuration Compliance: Passing🎉 No hardcoded values detected that have SSOT config equivalents! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_check_tablename_collisions()startup check in SLMmain.pyBaseMetaData objectscreate_all/ migrations so conflicts are caught immediatelyTest plan
🤖 Generated with Claude Code