Expose alpha-shape attachment info via with_attachment kwarg#16
Open
anigmetov wants to merge 1 commit intomrzv:masterfrom
Open
Expose alpha-shape attachment info via with_attachment kwarg#16anigmetov wants to merge 1 commit intomrzv:masterfrom
anigmetov wants to merge 1 commit intomrzv:masterfrom
Conversation
Add an opt-in form of fill_alpha_shapes (and weighted/periodic stubs) that, in addition to each simplex sigma and its alpha value, returns the vertex tuple of a Gabriel coface tau whose own squared circumradius equals alpha. For Gabriel sigma, tau == sigma; otherwise tau is found by walking sigma's cofaces (preferring lower-dim Gabriel ancestors) and matching alpha at the CGAL FT level. This is the data needed downstream to express alpha-filtration values as smooth, differentiable PyTorch operations on the input point cloud: the user computes circumradius^2(tau.vertices) in PyTorch and that yields alpha(sigma) with correct gradients. C++ entry points are added alongside the existing ones (no contract change for current C++ users). The Python bindings expose the new behavior via a default-False with_attachment kwarg; weighted and periodic variants raise NotImplementedError when the flag is set. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an opt-in form of fill_alpha_shapes (and weighted/periodic stubs) that, in addition to each simplex sigma and its alpha value, returns the vertex tuple of a Gabriel coface tau whose own squared circumradius equals alpha. For Gabriel sigma, tau == sigma; otherwise tau is found by walking sigma's cofaces (preferring lower-dim Gabriel ancestors) and matching alpha at the CGAL FT level.
This is the data needed downstream to express alpha-filtration values as smooth, differentiable PyTorch operations on the input point cloud: the user computes circumradius^2(tau.vertices) in PyTorch and that yields alpha(sigma) with correct gradients.
C++ entry points are added alongside the existing ones (no contract change for current C++ users). The Python bindings expose the new behavior via a default-False with_attachment kwarg; weighted and periodic variants raise NotImplementedError when the flag is set.