fix: middleware pass-through, reload visibility, workflow consistency#10
Merged
msilverblatt merged 4 commits intomasterfrom Mar 15, 2026
Merged
Conversation
Python and TypeScript middleware handlers returning None/undefined (meaning "no changes") would default arguments_json and result_json to empty strings, silently wiping tool arguments. Now defaults to the request's original values, matching Go and Rust behavior.
The initial handshake sent DisableToolsRequest for hidden tools, but the reload handler did not. After hot reload, hidden workflow steps would become visible to the LLM.
The onError path returned disableTools: [] while the normal transition path correctly computed the full disable set. Old step tools would remain visible during error recovery.
Added pre_workflow_tools to WorkflowState, snapshotted at workflow start. On terminal completion or cancel, these tools are re-enabled via the ToolResult. Previously external tools disabled during the workflow would stay hidden permanently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes middleware argument preservation, hidden tool visibility after reload, and workflow tool management consistency across all 4 SDKs.
Changes
Middleware pass-through (HIGH)
arguments_jsonto empty string instead of preserving the request's original valuesReload visibility (MEDIUM — all 4 SDKs)
sendDisableHiddenToolscall after reload in Go, Python, TypeScript, and RustTypeScript workflow onError (MEDIUM)
disableTools(was returning empty array)Rust workflow restore (MEDIUM)
pre_workflow_toolstracking toWorkflowStateTest plan